Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schematics collection JSON. #11839

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

piotrtomiak
Copy link
Contributor

@piotrtomiak piotrtomiak commented Jun 19, 2018

Add missing quote and remove redundant aliases. Latest Angular CLI
releases refuses to generate anything without those changes.

@piotrtomiak piotrtomiak requested a review from amcdnl as a code owner June 19, 2018 09:06
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jun 19, 2018
@piotrtomiak
Copy link
Contributor Author

Aims at fixing #11836

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 19, 2018
@piotrtomiak piotrtomiak changed the title Add missing quote. Fix schematics collection JSON. Jun 19, 2018
amcdnl
amcdnl previously requested changes Jun 24, 2018
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the aliases for backwards compat for now.

@piotrtomiak
Copy link
Contributor Author

@amcdnl - what is the lowest version of Angular CLI you want to be compatible with?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

I think it's fine as long as the documentation is still correct

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 25, 2018
@ngbot
Copy link

ngbot bot commented Jun 25, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Add missing quote and remove redundant aliases. Latest Angular CLI
releases refuses to generate anything without those changes.
@rijomonr
Copy link

rijomonr commented Jun 29, 2018

D:\angular5\almni-ng>ng add @angular/material
Installing packages for tooling via npm.
Collection "@angular/material" cannot be resolved.
Error: Collection "@angular/material" cannot be resolved.
at NodeModulesEngineHost._resolveCollectionPath (D:\angular5\almni-ng\node_m
odules@angular-devkit\schematics\tools\node-module-engine-host.js:88:15)
at NodeModulesEngineHost.createCollectionDescription (D:\angular5\almni-ng\n
ode_modules@angular-devkit\schematics\tools\file-system-engine-host-base.js:106
:27)
at SchematicEngine._createCollectionDescription (D:\angular5\almni-ng\node_m
odules@angular-devkit\schematics\src\engine\engine.js:78:40)
at SchematicEngine.createCollection (D:\angular5\almni-ng\node_modules@angu
lar-devkit\schematics\src\engine\engine.js:71:43)
at Object.getCollection (D:\angular5\almni-ng\node_modules@angular\cli\util
ities\schematics.js:28:31)
at AddCommand.getOptions (D:\angular5\almni-ng\node_modules@angular\cli\mod
els\schematic-command.js:193:41)
at AddCommand. (D:\angular5\almni-ng\node_modules@angular\cli\co
mmands\add.js:30:49)
at Generator.next ()
at D:\angular5\almni-ng\node_modules@angular\cli\commands\add.js:7:71
at new Promise ()

Angular CLI: 6.0.8
Node: 8.11.1
OS: win32 x64
Angular: 6.0.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.6.8
@angular-devkit/build-angular 0.6.8
@angular-devkit/build-optimizer 0.6.8
@angular-devkit/core 0.6.8
@angular-devkit/schematics 0.6.8
@angular/cdk 6.3.1-825d35c
@angular/cli 6.0.8
@angular/material 6.3.1-825d35c
@ngtools/webpack 6.0.8
@schematics/angular 0.6.8
@schematics/update 0.6.8
rxjs 6.2.1
typescript 2.7.2
webpack 4.8.3

D:\angular5\almni-ng>

@piotrtomiak
Copy link
Contributor Author

@rijomonr - the fix is not yet released.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants